Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The prompt generator in TDI adds unneaded white space - this should fix that #23

Merged
merged 2 commits into from
Dec 4, 2024
Merged

The prompt generator in TDI adds unneaded white space - this should fix that #23

merged 2 commits into from
Dec 4, 2024

Conversation

matanninio
Copy link
Collaborator

No description provided.

@SagiPolaczek
Copy link
Contributor

SagiPolaczek commented Nov 26, 2024 •
edited
Loading

EDIT:
Never mind, missed the space (which is the problem lol)

What is the exact issue? I couldn't reproduce it with a toy example:

>>> (
... "a"\
... "b"
... )
'ab'
>>> (
... "a"
... "b"
... )
'ab'

SagiPolaczek
SagiPolaczek approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@SagiPolaczek SagiPolaczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@matanninio matanninio merged commit b6c491b into main Dec 4, 2024
2 checks passed
@matanninio matanninio deleted the fix-extra-white-space-in-prompt branch December 4, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagiPolaczek SagiPolaczek SagiPolaczek approved these changes

@mosheraboh mosheraboh Awaiting requested review from mosheraboh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matanninio @SagiPolaczek